Skip to content

ESB-1154 refactored error handling, updated tests#346

Merged
MEM2677 merged 8 commits into
release/7.5from
ESB-1154
Jul 8, 2026
Merged

ESB-1154 refactored error handling, updated tests#346
MEM2677 merged 8 commits into
release/7.5from
ESB-1154

Conversation

@MEM2677

@MEM2677 MEM2677 commented Jul 2, 2026

Copy link
Copy Markdown
Member

Stacktrace replaced with a WARN

Instead of asserting an exception is thrown, each test now asserts the executed Solr query equals +(entity_group:free) — i.e., the malicious field was dropped entirely and only the safe access-control clause reached Solr.

@MEM2677 MEM2677 requested a review from ffalqui July 2, 2026 13:48
@MEM2677 MEM2677 changed the title ESB-1154 refacotred error handling, updated tests ESB-1154 refactored error handling, updated tests Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

PUBLICATION for COMMIT ID ``

IMG/TAG: entando/entando-de-app-tomcat:7.5.0-ESB-1154-PR346
IMG/SHA: entando/entando-de-app-tomcat@sha256:05ac88bf88f9338492508af85f4964d94bb7fee4d32fa830fb2f634d3774ce6d

@MEM2677

MEM2677 commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Only one exception is reported, and displays the following error:

Schermata del 2026-07-07 11-14-07

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

PUBLICATION for COMMIT ID ``

IMG/TAG: entando/entando-de-app-tomcat:7.5.0-ESB-1154-PR346
IMG/SHA: entando/entando-de-app-tomcat@sha256:4134c1c64f3fbc1664f3698120c916e07a98374052b7e1711ac76a3ec157eeca

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

PUBLICATION for COMMIT ID ``

IMG/TAG: entando/entando-de-app-tomcat:7.5.0-ESB-1154-PR346
IMG/SHA: entando/entando-de-app-tomcat@sha256:ededca01c9a7d6552e486935eebb36306801f2f1d8b84cf34793de964fd5440f

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

PUBLICATION for COMMIT ID ``

IMG/TAG: entando/entando-de-app-tomcat:7.5.0-ESB-1154-PR346
IMG/SHA: entando/entando-de-app-tomcat@sha256:8113f3bf4be07523d9ca2103c98d1e8afdfb0f86064d4d2779a9716b85ea2c38

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

PUBLICATION for COMMIT ID ``

IMG/TAG: entando/entando-de-app-tomcat:7.5.0-ESB-1154-PR346
IMG/SHA: entando/entando-de-app-tomcat@sha256:a6f371f518dad7b74e095389c1d39c99ce5438cbd926a1327c419f8223f69d4e

@MEM2677

MEM2677 commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

ESB-1154 — Advanced Content Search: hardened filter handling

Component: solr-plugin — AdvContentSearchController
(GET /api/plugins/advcontentsearch/contents, GET /api/plugins/advcontentsearch/facetedcontents)

Summary

The Advanced Content Search endpoints no longer return HTTP 500 for a range of malformed,
empty, or full-text/attachment inputs. Filter input is validated and handled explicitly, and a
failed Solr query now degrades to an empty 200 result instead of crashing while building the
response.

No change to successful requests

Valid requests are unaffected: returned content, result counts, ordering, faceting, and
pagination metadata are identical to previous releases. The only observable differences are the
error responses listed above.

Upgrade impact / client action

  • Clients that (incorrectly) relied on receiving a 500 for the cases above should expect
    400 or 200 accordingly.
  • Clients sending filters without a searchable attribute (other than full-text) will now
    receive a descriptive 400 — update those requests to include a valid attribute or
    entityAttr, or mark the filter fullText=true.
  • No API contract, request schema, or successful-response format changes.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PUBLICATION for COMMIT ID ``

IMG/TAG: entando/entando-de-app-tomcat:7.5.0-ESB-1154-PR346
IMG/SHA: entando/entando-de-app-tomcat@sha256:435c43aa0de89459bb38eb7b09f1ddadd29416f64582d8ee282c4b870541d06d

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.1% Coverage on New Code
3.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PUBLICATION for COMMIT ID ``

IMG/TAG: entando/entando-de-app-tomcat:7.5.0-ESB-1154-PR346
IMG/SHA: entando/entando-de-app-tomcat@sha256:7d8b6decf660f6ca0254a8abbc4a83e7f9159f7ba81b63a4820c252a2295c5e2

@MEM2677 MEM2677 merged commit 30757b0 into release/7.5 Jul 8, 2026
4 checks passed
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PUBLICATION for COMMIT ID ``

IMG/TAG: entando/entando-de-app-tomcat:7.5.0-ESB-1154-PR346
IMG/SHA: entando/entando-de-app-tomcat@sha256:adbdb6b09dd23bf2c3c425888ec19f357e7214dde7b69b7d264e61fc213e8518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffalqui ffalqui ffalqui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MEM2677 @ffalqui